feat: filter ordinals #1386
Merged
feat: filter ordinals #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure about the usage of positive/negative ordinals, so maybe the |
reegnz
force-pushed
the
feat/filter_ordinals
branch
from
94a4ce0 to
625b63e
Compare
|
Actually I think I need to separate the ordinal-based sorting from the before/after namespace filters part. |
Implements fluent#1384 Signed-off-by: Zoltán Reegn <[email protected]>
reegnz
force-pushed
the
feat/filter_ordinals
branch
from
625b63e to
fc4ea21
Compare
|
@reegnz would you take a look at the CI error below? |
Signed-off-by: Zoltán Reegn <[email protected]>
reegnz
force-pushed
the
feat/filter_ordinals
branch
from
41dc7ef to
86652be
Compare
|
@benjaminhuo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1384
What this PR does / why we need it
See #1384 for explanation.
Which issue(s) this PR fixes
Fixes #1384
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc